Skip to content

Conversation

@Alex6323
Copy link
Contributor

@Alex6323 Alex6323 commented Oct 13, 2025

Closes #333

This PR here adds BCS conversion to all FFI exposed core types that have a BCS definition and exposes them. Since this is very repetitive I implemented this using a declarative macro, which also makes it easier in the future to add this to other types if that may be necessary.

@Alex6323 Alex6323 linked an issue Oct 13, 2025 that may be closed by this pull request
@Alex6323 Alex6323 marked this pull request as draft October 13, 2025 07:51
@Alex6323 Alex6323 marked this pull request as ready for review October 20, 2025 13:13
@Alex6323 Alex6323 changed the title feat(iota-sdk-ffi): Expose bcs conversion methods/ctors feat(iota-sdk-ffi): Add from/to_bcs methods to all core types Oct 20, 2025
@Alex6323 Alex6323 changed the title feat(iota-sdk-ffi): Add from/to_bcs methods to all core types feat(iota-sdk-ffi): Add from/to_bcs methods to all FFI exposed core types Oct 20, 2025
Copy link
Contributor

@DaughterOfMars DaughterOfMars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we're not doing the primitive types in this PR?

@DaughterOfMars
Copy link
Contributor

Need to update the bindings

@Alex6323
Copy link
Contributor Author

Alex6323 commented Oct 21, 2025

So we're not doing the primitive types in this PR?

I guess not, unless we want to expand issue #231 to mean all types (Thoralf said intended only the primitives wit that isse ... I'll edit it to make this clear). I can however create a separate issue for the iota types and link that in the description.

@Alex6323
Copy link
Contributor Author

Need to update the bindings

with empty lines (kotlin) 😭

@Alex6323
Copy link
Contributor Author

So we're not doing the primitive types in this PR?

I guess not, unless we want to expand issue #231 to mean all types (Thoralf said intended only the primitives wit that isse ... I'll edit it to make this clear). I can however create a separate issue for the iota types and link that in the description.

I created a separate issue #333 and updated #231 with the original intent as clarified in Slack with @Thoralf-M

@DaughterOfMars DaughterOfMars merged commit e21f5d4 into sdk-bindings Oct 23, 2025
14 checks passed
@DaughterOfMars DaughterOfMars deleted the feat/expose-bcs-conversion branch October 23, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose IOTA core types bcs conversion to bindings

4 participants