-
Notifications
You must be signed in to change notification settings - Fork 3
feat(iota-sdk-ffi): Add from/to_bcs methods to all FFI exposed core types
#282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
from/to_bcs methods to all core types
from/to_bcs methods to all core typesfrom/to_bcs methods to all FFI exposed core types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we're not doing the primitive types in this PR?
|
Need to update the bindings |
I guess not, unless we want to expand issue #231 to mean all types (Thoralf said intended only the primitives wit that isse ... I'll edit it to make this clear). I can however create a separate issue for the iota types and link that in the description. |
with empty lines (kotlin) 😭 |
I created a separate issue #333 and updated #231 with the original intent as clarified in Slack with @Thoralf-M |
Closes #333
This PR here adds BCS conversion to all FFI exposed core types that have a BCS definition and exposes them. Since this is very repetitive I implemented this using a declarative macro, which also makes it easier in the future to add this to other types if that may be necessary.